-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
zoned_time #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
zoned_time #4649
Conversation
8fb59ec to
a577b1c
Compare
vitaut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatter should be conditionally defined since zoned_time is a C++20 feature.
|
Hi @vitaut , yes I've checked CI logs and is trying to solve it |
2a9839b to
e10e922
Compare
6787974 to
94381c8
Compare
|
Now it should be fine. |
|
Hi @vitaut , can you please review once again, when you have a time of course. Thanks) |
94381c8 to
b43a520
Compare
vitaut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
b43a520 to
93c76b5
Compare
93c76b5 to
ba17df2
Compare
ba17df2 to
8c1889b
Compare
vitaut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but please add a unit test to chrono-test.cc.
|
Hi @vitaut , this PR provides zoned_time formatter.
With the result: